Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests, expression: move integration test in expression pkg to tests/integrationtest #47059

Merged
merged 9 commits into from
Sep 18, 2023

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Sep 18, 2023

What problem does this PR solve?

Issue Number: close #46679

Problem Summary: This is the last part in expression pkg. Move 19 test cases.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 18, 2023
@tiprow
Copy link

tiprow bot commented Sep 18, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 18, 2023
@Defined2014 Defined2014 changed the title tests, expression: move integration test in expression to tests/integrationtest tests, expression: move integration test in expression pkg to tests/integrationtest Sep 18, 2023
@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #47059 (71e33a2) into master (35add6f) will decrease coverage by 0.3720%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47059        +/-   ##
================================================
- Coverage   73.0786%   72.7066%   -0.3720%     
================================================
  Files          1336       1357        +21     
  Lines        398226     404535      +6309     
================================================
+ Hits         291018     294124      +3106     
- Misses        88467      91743      +3276     
+ Partials      18741      18668        -73     
Flag Coverage Δ
integration 30.4996% <ø> (?)
unit 73.0544% <ø> (-0.0242%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.9620% <ø> (-0.0252%) ⬇️
br 48.6835% <ø> (-4.2565%) ⬇️

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-18 07:54:36.096330827 +0000 UTC m=+504042.063918875: ☑️ agreed by hawkingrei.
  • 2023-09-18 09:23:30.412082165 +0000 UTC m=+509376.379670199: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit defa2ad into pingcap:master Sep 18, 2023
@Defined2014 Defined2014 deleted the finish-expression branch September 18, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move IT in expression/ to explaintest, files number 65
3 participants