Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: use slices.SortStableFunc to simple SortSampleItems #47009

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Sep 15, 2023

What problem does this PR solve?

Issue Number: ref #45933

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Sep 15, 2023
@hawkingrei hawkingrei changed the title statistics: use slices.SortFunc to simple SortSampleItems statistics: use slices.SortStableFunc to simple SortSampleItems Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #47009 (1e04b20) into master (95a35f6) will decrease coverage by 0.5187%.
Report is 1 commits behind head on master.
The diff coverage is 66.6666%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47009        +/-   ##
================================================
- Coverage   73.2353%   72.7166%   -0.5187%     
================================================
  Files          1335       1356        +21     
  Lines        397745     404027      +6282     
================================================
+ Hits         291290     293795      +2505     
- Misses        87809      91610      +3801     
+ Partials      18646      18622        -24     
Flag Coverage Δ
integration 30.3882% <66.6666%> (?)
unit 73.0783% <66.6666%> (-0.1570%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.9699% <ø> (-0.0072%) ⬇️
br 48.5779% <ø> (-4.3225%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 15, 2023
@hawkingrei hawkingrei requested a review from winoros September 15, 2023 11:00
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hi-rustin, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-15 10:56:05.483332287 +0000 UTC m=+255731.450920322: ☑️ agreed by qw4990.
  • 2023-09-15 11:58:20.321186225 +0000 UTC m=+259466.288774272: ☑️ agreed by hi-rustin.

@ti-chi-bot ti-chi-bot bot merged commit beb2a36 into pingcap:master Sep 15, 2023
@hawkingrei hawkingrei deleted the import_sort_sample_items branch September 15, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants