session_test: move tests #4699
Merged
session_test: move tests #4699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hanfei1991 Please fix CI. |
|
@shenli Please look at the description |
|
Got it! |
tiancaiamao
reviewed
Oct 9, 2017
new_session_test.go
Outdated
| tk.MustExec("begin") | ||
| tk.MustExec("insert into t set c2 = 31") | ||
| tk.MustQuery("select c1 from t where c2 = 31").Check(testkit.Rows("9")) | ||
| tk.MustQuery("update t set c2 = 44 where c2 = 2") |
new_session_test.go
Outdated
| tk.MustExec("execute stmt using @v2") | ||
| tk.MustExec("execute stmt using @v3") | ||
| tk.MustExec("deallocate prepare stmt") | ||
| tk.MustQuery("select c1 from t where c2 = 12").Check(testkit.Rows()) |
new_session_test.go
Outdated
|
|
||
| tk.MustExec("commit") | ||
|
|
||
| tk.MustQuery("select c1 from t where c2 = 12").Check(testkit.Rows()) |
|
@tiancaiamao PTAL |
|
LGTM |
tiancaiamao
approved these changes
Oct 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test will retry forever in mock-tikv. It seems to exist a lock that would never be resolved. I need a help @coocood @tiancaiamao