Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression, tests: move integration tests in expression pkg to tests/integration #46891

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Sep 12, 2023

What problem does this PR solve?

Issue Number: ref #46679

Problem Summary: mysql-tester already supported sorted_result, so move more test cases. Total test cases 9.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 12, 2023
@tiprow
Copy link

tiprow bot commented Sep 12, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #46891 (f26b1b7) into master (b7f0742) will decrease coverage by 0.5165%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46891        +/-   ##
================================================
- Coverage   73.3727%   72.8562%   -0.5165%     
================================================
  Files          1328       1349        +21     
  Lines        397074     404237      +7163     
================================================
+ Hits         291344     294512      +3168     
- Misses        87135      91114      +3979     
- Partials      18595      18611        +16     
Flag Coverage Δ
integration 27.8363% <ø> (?)
unit 73.4738% <ø> (+0.1011%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0019% <ø> (+0.0107%) ⬆️
br 48.6719% <ø> (-4.1699%) ⬇️

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 12, 2023

@hawkingrei: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,hi-rustin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 12, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-12 06:56:26.482407646 +0000 UTC m=+338768.406964039: ☑️ agreed by hawkingrei.
  • 2023-09-12 07:54:14.142925881 +0000 UTC m=+342236.067482273: ☑️ agreed by hi-rustin.

@ti-chi-bot ti-chi-bot bot merged commit dc99d14 into pingcap:master Sep 12, 2023
@Defined2014 Defined2014 deleted the move-more-tests branch September 13, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants