-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snap_backup: make snapshot backup exit once importing task detected #46854
Conversation
Signed-off-by: hillium <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @YuJuncen. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Yu Juncen <[email protected]>
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
…-exec-lightning-and-ebs
@YuJuncen: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@@ -87,9 +123,15 @@ func RunBackupEBS(c context.Context, g glue.Glue, cfg *BackupConfig) error { | |||
ctx, cancel := context.WithCancel(c) | |||
defer cancel() | |||
|
|||
cleanUp, err := checkConflictingTasksAndRegisterSelf(ctx, cfg.Config) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking here is improper. We'd better to keep move it to the task of suspend gc and schedule phase. Then we can release as soon as possible.
Close in favor of #47001 |
What problem does this PR solve?
Issue Number: ref #46850
Problem Summary:
See the issue.
What is changed and how it works?
Snapshot backup cannot be compatible with the importing for now. We will reject to start ebs backup once there are any importing tasks. (
ADD INDEX
by importing isn't covered yet!)Check List
Tests
I think we will test this via some automation then.
When
backup full --type aws-ebs
is running, try to start tide-lightning:Release note