Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sem: fix goleak #46845

Merged
merged 2 commits into from
Sep 11, 2023
Merged

sem: fix goleak #46845

merged 2 commits into from
Sep 11, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Sep 11, 2023

What problem does this PR solve?

Issue Number: close #46844

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed do-not-merge/needs-tests-checked size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Sep 11, 2023
@hawkingrei
Copy link
Member Author

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-11 04:24:18.694782167 +0000 UTC m=+243240.619338557: ☑️ agreed by xhebox.
  • 2023-09-11 04:24:32.785306224 +0000 UTC m=+243254.709862620: ☑️ agreed by Defined2014.

Signed-off-by: Weizhen Wang <[email protected]>
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #46845 (039be20) into master (262327f) will decrease coverage by 0.6046%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46845        +/-   ##
================================================
- Coverage   73.3236%   72.7190%   -0.6046%     
================================================
  Files          1322       1343        +21     
  Lines        396478     402765      +6287     
================================================
+ Hits         290712     292887      +2175     
- Misses        87245      91314      +4069     
- Partials      18521      18564        +43     
Flag Coverage Δ
integration 27.7455% <ø> (?)
unit 73.3402% <ø> (+0.0166%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 84.9717% <ø> (+0.0107%) ⬆️
br 48.3115% <ø> (-4.3162%) ⬇️

@ti-chi-bot ti-chi-bot bot merged commit e9ef984 into pingcap:master Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

goleak at the util/sem:sem_test
3 participants