Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: Don't support parser sql like t. [reservedKeyWord] #46789

Closed
wants to merge 7 commits into from

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #46778

Problem Summary: see #46778 (comment), I think it's a strange behavior in MySQL, not sure we should follow it or not.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 8, 2023
@tiprow
Copy link

tiprow bot commented Sep 8, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Defined2014 Defined2014 changed the title parser: Don't support parser sql like t. [reservedKeyWords] parser: Don't support parser sql like t. [reservedKeyWord] Sep 8, 2023
@Defined2014
Copy link
Contributor Author

Defined2014 commented Sep 8, 2023

/hold
hold it, until some users need it.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2023
parser
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from defined2014. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #46789 (3ddc49c) into master (d3d30f5) will decrease coverage by 0.6313%.
Report is 1485 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46789        +/-   ##
================================================
- Coverage   73.3326%   72.7013%   -0.6313%     
================================================
  Files          1322       1343        +21     
  Lines        396474     402764      +6290     
================================================
+ Hits         290745     292815      +2070     
- Misses        87208      91381      +4173     
- Partials      18521      18568        +47     
Flag Coverage Δ
integration 27.7404% <ø> (?)
unit 73.3233% <100.0000%> (-0.0094%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 84.9755% <100.0000%> (+0.0037%) ⬆️
br 48.3097% <ø> (-4.3321%) ⬇️

@Defined2014 Defined2014 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2023
@Defined2014
Copy link
Contributor Author

/retest

@tiprow
Copy link

tiprow bot commented Sep 11, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 11, 2023
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2023
Copy link

ti-chi-bot bot commented Nov 17, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Feb 17, 2024

@Defined2014: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build 3ddc49c link true /test build
idc-jenkins-ci-tidb/mysql-test 3ddc49c link true /test mysql-test
idc-jenkins-ci-tidb/unit-test 3ddc49c link true /test unit-test
idc-jenkins-ci-tidb/check_dev 3ddc49c link true /test check-dev
pull-integration-ddl-test 3ddc49c link true /test pull-integration-ddl-test
idc-jenkins-ci-tidb/check_dev_2 3ddc49c link true /test check-dev2
pull-mysql-client-test 3ddc49c link true /test pull-mysql-client-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Defined2014 Defined2014 deleted the fix-46778 branch March 29, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

query filter with . report syntax error
2 participants