Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix incompatible behaviors between prep and non-prep statements when converting date/time values (#42443) #46710

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #42443

What problem does this PR solve?

Issue Number: close #42439

Problem Summary: planner: fix incompatible behaviors between prep and non-prep statements when converting date/time values

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added epic/plan-cache release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Sep 6, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Sep 6, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 6, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 6, 2023
@YangKeao YangKeao requested a review from qw4990 September 6, 2023 03:52
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 6, 2023
@YangKeao
Copy link
Member

YangKeao commented Sep 7, 2023

/retest

1 similar comment
@YangKeao
Copy link
Member

YangKeao commented Sep 7, 2023

/retest

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-06 03:52:46.507007636 +0000 UTC m=+2503931.056023607: ☑️ agreed by YangKeao.
  • 2023-10-13 03:25:04.549012262 +0000 UTC m=+1368302.136122407: ☑️ agreed by qw4990.

@qw4990
Copy link
Contributor

qw4990 commented Oct 13, 2023

/retest-required

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@4350f8d). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #46710   +/-   ##
================================================
  Coverage               ?   73.6783%           
================================================
  Files                  ?       1085           
  Lines                  ?     348402           
  Branches               ?          0           
================================================
  Hits                   ?     256697           
  Misses                 ?      75245           
  Partials               ?      16460           

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 16, 2023
@ti-chi-bot ti-chi-bot bot merged commit dfa2b6f into pingcap:release-6.5 Oct 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. epic/plan-cache lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants