Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client-go: attach request source with retry info for coprocessor (#46509) #46705

Merged
merged 1 commit into from
Oct 16, 2023
Merged

client-go: attach request source with retry info for coprocessor (#46509) #46705

merged 1 commit into from
Oct 16, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #46509

What problem does this PR solve?

Issue Number: close #46514

Problem Summary:

What is changed and how it works?

Update client-go which will attach the request source with retry info for KV requests. This PR set the required options for coprocessor to enable the extra retry info.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

image

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Sep 6, 2023
@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 6, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 6, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 6, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 6, 2023
@cfzjywxk
Copy link
Contributor

cfzjywxk commented Oct 7, 2023

@you06 Please resolve the conflicts and pick it to release-7.1

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 16, 2023
@you06
This is an automated cherry-pick of pingcap#46509
c26099c 
Signed-off-by: ti-chi-bot <[email protected]>

resolve conflict

Signed-off-by: you06 <[email protected]>
@you06 you06 force-pushed the cherry-pick-46509-to-release-7.1 branch from e642b04 to c26099c Compare October 16, 2023 05:33
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 16, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, ekexium

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-16 05:57:41.10347329 +0000 UTC m=+1636658.690583435: ☑️ agreed by cfzjywxk.
  • 2023-10-16 06:14:53.414262758 +0000 UTC m=+1637691.001372904: ☑️ agreed by ekexium.

@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2023

@cfzjywxk: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@you06
Copy link
Contributor

you06 commented Oct 16, 2023

/retest

@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@6de161e). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-7.1     #46705   +/-   ##
================================================
  Coverage               ?   73.5317%           
================================================
  Files                  ?       1205           
  Lines                  ?     377822           
  Branches               ?          0           
================================================
  Hits                   ?     277819           
  Misses                 ?      82357           
  Partials               ?      17646

@ti-chi-bot ti-chi-bot bot merged commit 359aea8 into pingcap:release-7.1 Oct 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekexium ekexium ekexium approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

Assignees

@you06 you06

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @cfzjywxk @you06 @ekexium