-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: make TestUpgradeWithPauseDDL stable #46692
Conversation
Hi @zimulala. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[FORMAT CHECKER NOTIFICATION] Notice: To remove the For example:
📖 For more info, you can check the "Contribute Code" section in the development guide. |
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46692 +/- ##
================================================
- Coverage 73.3586% 72.7009% -0.6578%
================================================
Files 1315 1339 +24
Lines 395675 402453 +6778
================================================
+ Hits 290262 292587 +2325
- Misses 86932 91346 +4414
- Partials 18481 18520 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #46388
Problem Summary:
The job may be
pausing
, we only check it usespaused
.What is changed and how it works?
pausing
orpaused
to check whether the job is pausing.checkDDLJobState
from the same two pieces of judgment code.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.