Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix taskNodes temporarily #46671

Merged
merged 2 commits into from
Sep 5, 2023
Merged

ddl: fix taskNodes temporarily #46671

merged 2 commits into from
Sep 5, 2023

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Sep 5, 2023

Signed-off-by: xhe [email protected]<!--

Thank you for contributing to TiDB!

PR Title Format:

  1. pkg [, pkg2, pkg3]: what's changed
  2. *: what's changed

-->

What problem does this PR solve?

Issue Number: ref #46258

Problem Summary: When dispatcher fails, the new dispatcher will pick up the running task while not invoking onNextStage. In this case, we need to fallback to task table for taskNodes.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 5, 2023
@tiprow
Copy link

tiprow bot commented Sep 5, 2023

Hi @xhebox. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 5, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 5, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 5, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-05 07:26:24.055339958 +0000 UTC m=+2430348.604355929: ☑️ agreed by tangenta.
  • 2023-09-05 07:29:31.882028821 +0000 UTC m=+2430536.431044808: ☑️ agreed by ywqzzy.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #46671 (3346e95) into master (db570ea) will decrease coverage by 0.8337%.
Report is 6 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46671        +/-   ##
================================================
- Coverage   73.3586%   72.5250%   -0.8337%     
================================================
  Files          1315       1336        +21     
  Lines        395675     403524      +7849     
================================================
+ Hits         290262     292656      +2394     
- Misses        86932      92247      +5315     
- Partials      18481      18621       +140     
Flag Coverage Δ
integration 25.4076% <0.0000%> (?)
unit 73.3508% <0.0000%> (-0.0079%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 84.9689% <ø> (+0.0108%) ⬆️
br 48.1092% <ø> (-4.3283%) ⬇️

@xhebox
Copy link
Contributor Author

xhebox commented Sep 5, 2023

/retest

@tiprow
Copy link

tiprow bot commented Sep 5, 2023

@xhebox: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 66fe053 into pingcap:master Sep 5, 2023
4 of 9 checks passed
@xhebox xhebox deleted the d1 branch April 7, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants