-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix taskNodes temporarily #46671
Conversation
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
Hi @xhebox. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46671 +/- ##
================================================
- Coverage 73.3586% 72.5250% -0.8337%
================================================
Files 1315 1336 +21
Lines 395675 403524 +7849
================================================
+ Hits 290262 292656 +2394
- Misses 86932 92247 +5315
- Partials 18481 18621 +140
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@xhebox: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: xhe [email protected]<!--
Thank you for contributing to TiDB!
PR Title Format:
-->
What problem does this PR solve?
Issue Number: ref #46258
Problem Summary: When dispatcher fails, the new dispatcher will pick up the running task while not invoking
onNextStage
. In this case, we need to fallback to task table fortaskNodes
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.