Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cop: cop request should contains buckets version #46446

Merged
merged 7 commits into from
Sep 4, 2023

Conversation

bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Aug 28, 2023

What problem does this PR solve?

Issue Number: close #46557
ref: tikv/client-go#918

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)
image

Side effects

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: bufferflies <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Aug 28, 2023
@sre-bot
Copy link
Contributor

sre-bot commented Aug 28, 2023

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 28, 2023
@tiprow
Copy link

tiprow bot commented Aug 28, 2023

Hi @bufferflies. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: bufferflies <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #46446 (b82ab6e) into master (a427113) will decrease coverage by 0.6775%.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46446        +/-   ##
================================================
- Coverage   73.3303%   72.6529%   -0.6775%     
================================================
  Files          1310       1331        +21     
  Lines        394940     401154      +6214     
================================================
+ Hits         289611     291450      +1839     
- Misses        86881      91201      +4320     
- Partials      18448      18503        +55     
Flag Coverage Δ
integration 25.4140% <100.0000%> (?)
unit 73.3375% <100.0000%> (+0.0071%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 84.9520% <ø> (ø)
br 47.9985% <ø> (-4.3218%) ⬇️

@bufferflies
Copy link
Contributor Author

/ping @crazycs520 @rleungx

Signed-off-by: bufferflies <[email protected]>
@bufferflies
Copy link
Contributor Author

/cc @crazycs520

@ti-chi-bot ti-chi-bot bot requested a review from crazycs520 August 31, 2023 01:55
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 31, 2023
@rleungx
Copy link
Member

rleungx commented Aug 31, 2023

CI failed @bufferflies

@bufferflies
Copy link
Contributor Author

/rebuild

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 31, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-31 02:39:18.918925588 +0000 UTC m=+1981123.467941575: ☑️ agreed by rleungx.
  • 2023-08-31 07:51:15.209392293 +0000 UTC m=+1999839.758408281: ☑️ agreed by crazycs520.

@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please sign the CLA.

@bufferflies
Copy link
Contributor Author

/test unit-test

@tiprow
Copy link

tiprow bot commented Aug 31, 2023

@bufferflies: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bufferflies
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 31, 2023
@bufferflies
Copy link
Contributor Author

/retest

@bufferflies
Copy link
Contributor Author

/retest-required

@tiprow
Copy link

tiprow bot commented Sep 1, 2023

@bufferflies: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 1b97e7a link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hawkingrei
Copy link
Member

/test all

Signed-off-by: bufferflies <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 4, 2023
@bufferflies
Copy link
Contributor Author

/test unit-test

@tiprow
Copy link

tiprow bot commented Sep 4, 2023

@bufferflies: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 1cf3201 into pingcap:master Sep 4, 2023
7 of 9 checks passed
@bufferflies bufferflies deleted the buckets_version branch September 4, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cop request should add the current bucket version
5 participants