Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: use std/slices to replace exp/slices #46433

Merged
merged 7 commits into from
Aug 28, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 25, 2023

What problem does this PR solve?

Issue Number: ref #45933

close #45976

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 25, 2023
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Attention: Patch coverage is 72.22222% with 10 lines in your changes missing coverage. Please review.

Project coverage is 72.7436%. Comparing base (b390a09) to head (8944866).
Report is 3547 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46433        +/-   ##
================================================
- Coverage   73.4112%   72.7436%   -0.6676%     
================================================
  Files          1295       1316        +21     
  Lines        393771     399955      +6184     
================================================
+ Hits         289072     290942      +1870     
- Misses        86334      90582      +4248     
- Partials      18365      18431        +66     
Flag Coverage Δ
integration 25.6637% <0.0000%> (?)
unit 73.4223% <72.2222%> (+0.0111%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0741% <ø> (+0.0108%) ⬆️
br 47.9526% <0.0000%> (-4.3719%) ⬇️

Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei requested a review from Defined2014 August 28, 2023 02:21
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 28, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-26 10:02:45.561185675 +0000 UTC m=+1575730.110201662: ☑️ agreed by lance6716.
  • 2023-08-28 02:24:54.791242556 +0000 UTC m=+1721059.340258543: ☑️ agreed by Defined2014.

@ti-chi-bot ti-chi-bot bot merged commit c11a999 into pingcap:master Aug 28, 2023
@D3Hunter D3Hunter mentioned this pull request Jun 4, 2024
13 tasks
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jun 4, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #53787.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 4, 2024
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parser: golang.org/x/exp/slices usage is outdated
4 participants