Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binlog: fix the wrong fatal error when binlog is too large (#46365) #46379

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 24, 2023

This is an automated cherry-pick of #46365

What problem does this PR solve?

Issue Number: close #28659

Problem Summary:

What is changed and how it works?

Catch both send and receive large binlog error.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. Create a cluster with binlog
  2. Commit a very large delete statement over 2G.
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Aug 24, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 24, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 28, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Aug 28, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 31, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Sep 13, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 21, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackysp, lichunzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-24 06:21:25.570510736 +0000 UTC m=+1389650.119526723: ☑️ agreed by jackysp.
  • 2023-10-08 00:45:23.20602202 +0000 UTC m=+926720.793132316: ☑️ agreed by lichunzhu.

@lichunzhu
Copy link
Contributor

/retest

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@d7ce2f2). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #46379   +/-   ##
================================================
  Coverage               ?   73.6673%           
================================================
  Files                  ?       1085           
  Lines                  ?     348389           
  Branches               ?          0           
================================================
  Hits                   ?     256649           
  Misses                 ?      75269           
  Partials               ?      16471           

@ti-chi-bot ti-chi-bot bot merged commit 62a0305 into pingcap:release-6.5 Oct 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants