-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix potential panic when generating hints in statement summary #46312
Conversation
Signed-off-by: Jack Yu <[email protected]>
/run-all-tests |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46312 +/- ##
================================================
- Coverage 73.3535% 73.0902% -0.2634%
================================================
Files 1284 1314 +30
Lines 393272 405247 +11975
================================================
+ Hits 288479 296196 +7717
- Misses 86425 90505 +4080
- Partials 18368 18546 +178
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
/retest |
Signed-off-by: Jack Yu <[email protected]>
Signed-off-by: Jack Yu <[email protected]>
/check-issue-triage-complete |
1 similar comment
/check-issue-triage-complete |
/run-check-issue-triage-complete |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #46311
Problem Summary:
Use empty slices to init
PlannerSelectBlockAsName
to avoid panic when dereferencing.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.