Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: avoid possible infinite loop checking tikv gc and scheduling status (#46078) #46196

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions br/pkg/task/backup_ebs.go
Original file line number Diff line number Diff line change
Expand Up @@ -295,13 +295,13 @@ func waitAllScheduleStoppedAndNoRegionHole(ctx context.Context, cfg Config, mgr
} else {
log.Warn("failed to wait schedule, will retry later", zap.Error(err2))
}
continue
}

log.Info("all leader regions got, start checking hole", zap.Int("len", len(allRegions)))
} else {
log.Info("all leader regions got, start checking hole", zap.Int("len", len(allRegions)))

if !isRegionsHasHole(allRegions) {
return nil
if !isRegionsHasHole(allRegions) {
return nil
}
log.Info("Regions has hole, needs sleep and retry")
}
time.Sleep(backoffer.ExponentialBackoff())
}
Expand Down