*: use std/slices to replace exp/slices #46169
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46169 +/- ##
=================================================
- Coverage 73.3507% 25.5827% -47.7681%
=================================================
Files 1283 1148 -135
Lines 394308 349755 -44553
=================================================
- Hits 289228 89477 -199751
- Misses 86642 249533 +162891
+ Partials 18438 10745 -7693
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test all |
| @@ -143,12 +143,15 @@ func (m *memIndexReader) getMemRows(ctx context.Context) ([][]types.Datum, error | |||
| } | |||
|
|
|||
| if m.keepOrder && m.table.GetPartitionInfo() != nil { | |||
| slices.SortFunc(m.addedRows, func(a, b []types.Datum) bool { | |||
| slices.SortFunc(m.addedRows, func(a, b []types.Datum) int { | |||
| ret, err1 := m.compare(m.ctx.GetSessionVars().StmtCtx, a, b) | |||
There was a problem hiding this comment.
I'd like to add some comments to m.compare to summarize the meaning of return values 😂
| @@ -143,12 +143,15 @@ func (m *memIndexReader) getMemRows(ctx context.Context) ([][]types.Datum, error | |||
| } | |||
|
|
|||
| if m.keepOrder && m.table.GetPartitionInfo() != nil { | |||
| slices.SortFunc(m.addedRows, func(a, b []types.Datum) bool { | |||
| slices.SortFunc(m.addedRows, func(a, b []types.Datum) int { | |||
| ret, err1 := m.compare(m.ctx.GetSessionVars().StmtCtx, a, b) | |||
There was a problem hiding this comment.
Better change the compare function
Line 295 in 4fc7970
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
|
@hawkingrei: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@hawkingrei: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #45933
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.