Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: refactor Join and Limit's ResolveIndices (#45831) #46091

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

winoros
Copy link
Member

@winoros winoros commented Aug 15, 2023

This is a manual cherry-pick of #45831

What problem does this PR solve?

Issue Number: close #45758 , close #45805

Problem Summary:

What is changed and how it works?

In #45158, we use ResolveIndices for the inline projection's column matching.

It's possible that the join/limit's child(ren)'s output columns are [col0, col0, col1].
And if we call ResolveIndices, the two col0 from join/limit will resolve their indexes to the first col0. But actually, the first col0 should resolve to the first col0 of its child(ren). The second should resolve to the second of its child(ren).

This pr aims to solve this issue.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Aug 15, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 15, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Aug 15, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@1f6c883). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #46091   +/-   ##
================================================
  Coverage               ?   73.6662%           
================================================
  Files                  ?       1083           
  Lines                  ?     347486           
  Branches               ?          0           
================================================
  Hits                   ?     255980           
  Misses                 ?      75067           
  Partials               ?      16439           

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [qw4990,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 15, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-15 04:44:33.474220103 +0000 UTC m=+606238.023236090: ☑️ agreed by qw4990.
  • 2023-08-15 05:15:40.044927927 +0000 UTC m=+608104.593943914: ☑️ agreed by time-and-fate.

@ti-chi-bot ti-chi-bot bot merged commit c518a89 into pingcap:release-6.5 Aug 15, 2023
@winoros winoros deleted the pick-6.5 branch August 15, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants