-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
status: add new http status API for get meta regions. #4597
Conversation
@hicqu |
resp, err := http.Get("http://127.0.0.1:10090/regions/meta") | ||
c.Assert(err, IsNil) | ||
defer resp.Body.Close() | ||
c.Assert(resp.StatusCode, Equals, http.StatusOK) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not verify the body?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we do verify whether the body is a valid json array or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not verify if it is region meta?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. PTAL, thanks!
@hicqu Please address the comment. |
/run-all-test |
LGTM |
LGTM. |
Add a new API( /regions/meta ) for get meta regions.
The return JSON is:
Meta means those TiKV keys which start with
m
.@siddontang , PTAL, thanks.