-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: revise the structure of table conflict_error_v1
and add index for faster search
#45799
Conversation
…dex for faster search
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #45799 +/- ##
================================================
+ Coverage 73.3463% 73.3607% +0.0143%
================================================
Files 1271 1274 +3
Lines 393001 393678 +677
================================================
+ Hits 288252 288805 +553
- Misses 86371 86468 +97
- Partials 18378 18405 +27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test pull-br-integration-test |
@lance6716: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
merge master into issue45774-step1
/cc @lichunzhu |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, lichunzhu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #45774
Problem Summary:
We need to support
replace
mode for lightning post-import conflict detection:To resolve rows with conflict, instead of deleting all the rows that are engaged in conflict (the algorithm for
remove
), we delete some of the rows with conflict and reserve other rows that can be kept and not cause conflict anymore. Under this circumstance, we only delete the necessary rows to resolve conflicts, so that we can keep more original rows than remove mode as long as the conflicts are resolved.What is changed and how it works?
This PR is the first step for implementing the
replace
algorithm.I revised the structure of the table that record data KV conflicts and index KV conflicts, which is
conflict_error_v1
. I added index forindex_name
to track and search rows with conflicts faster in the later steps.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.