Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessiontxn/staleread: more accurate stale ts (#44272) #45760

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #44272

What problem does this PR solve?

Issue Number: close #44215

Problem Summary:

What is changed and how it works?

When calculate as-of expr, calculate now expression by cached PD ts, the stale read ts will be more accurate, and there will also be less stale read fallback.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

I also test with 100ms staleness read:

  • resolved-ts.advance-ts-interval: 100ms

nightly:

a

this PR:

b

  • resolved-ts.advance-ts-interval: 50ms

nightly:

c

this PR:

d

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Use more accurate stale read ts.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/transaction SIG:Transaction size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Aug 2, 2023
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels Aug 2, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 2, 2023
Signed-off-by: you06 <[email protected]>
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@25e2528). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #45760   +/-   ##
================================================
  Coverage               ?   73.9828%           
================================================
  Files                  ?       1203           
  Lines                  ?     381299           
  Branches               ?          0           
================================================
  Hits                   ?     282096           
  Misses                 ?      81730           
  Partials               ?      17473           

@you06
Copy link
Contributor

you06 commented Aug 17, 2023

@cfzjywxk @zyguan PTAL

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, crazycs520

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cfzjywxk,crazycs520]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-02 10:46:46.257381448 +0000 UTC m=+268690.199729977: ☑️ agreed by crazycs520.
  • 2023-08-17 06:02:14.948343036 +0000 UTC m=+783699.497359023: ☑️ agreed by cfzjywxk.

@ti-chi-bot ti-chi-bot bot merged commit 79a02af into pingcap:release-7.1 Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/transaction SIG:Transaction size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants