-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sessiontxn/staleread: more accurate stale ts (#44272) #45760
sessiontxn/staleread: more accurate stale ts (#44272) #45760
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: you06 <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #45760 +/- ##
================================================
Coverage ? 73.9828%
================================================
Files ? 1203
Lines ? 381299
Branches ? 0
================================================
Hits ? 282096
Misses ? 81730
Partials ? 17473 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, crazycs520 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #44272
What problem does this PR solve?
Issue Number: close #44215
Problem Summary:
What is changed and how it works?
When calculate as-of expr, calculate
now
expression by cached PD ts, the stale read ts will be more accurate, and there will also be less stale read fallback.Check List
Tests
I also test with 100ms staleness read:
nightly:
this PR:
nightly:
this PR:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.