lightning: fix lightning TLS.WithHost to access the correct host #45749

lichunzhu · 2023-08-02T06:37:05Z

What problem does this PR solve?

Issue Number: close #45747

Problem Summary:

What is changed and how it works?

TrimPrefix before WithHost

Check List

Tests

Unit test

Side effects

None

Documentation

None

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2023-08-02T06:37:26Z

Hi @lichunzhu. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lichunzhu · 2023-08-02T06:37:41Z

/run-br-integration-test

codecov · 2023-08-02T06:59:21Z

Codecov Report

Merging #45749 (bb979f2) into master (412fa13) will increase coverage by 0.2139%.
Report is 10 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #45749        +/-   ##
================================================
+ Coverage   73.3314%   73.5453%   +0.2139%     
================================================
  Files          1271       1274         +3     
  Lines        392954     395107      +2153     
================================================
+ Hits         288159     290583      +2424     
+ Misses        86415      86213       -202     
+ Partials      18380      18311        -69

Flag	Coverage Δ
integration	`78.1388% <ø> (?)`
unit	`73.5375% <100.0000%> (+0.2060%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`54.0444% <ø> (ø)`
parser	`85.0467% <ø> (ø)`
br	`52.0692% <100.0000%> (+0.0709%)`	⬆️

lichunzhu · 2023-08-02T07:12:03Z

/run-br-integration-test

lance6716 · 2023-08-02T08:08:59Z

/test pull-br-integration-test

tiprow · 2023-08-02T08:09:31Z

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-08-02T08:41:53Z

@lichunzhu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-br-integration-test	`4e5c9aa`	link	true	`/test pull-br-integration-test`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

lichunzhu · 2023-08-02T09:35:38Z

@GMHDBJD @lance6716 @D3Hunter PTAL
The failed test cases seem to be caused by TiFlash problem

lance6716 · 2023-08-02T08:09:49Z

br/pkg/lightning/common/security.go

 // WithHost creates a new TLS instance with the host replaced.
 func (tc *TLS) WithHost(host string) *TLS {
+	host = strings.TrimPrefix(host, "http://")


can we remove url = "https://" + host instead?

Some host has a scheme while some doesn't. To avoid users configure a wrong url, I remove both scheme.

lance6716 · 2023-08-02T10:26:30Z

/approve

lichunzhu · 2023-08-03T06:19:45Z

/test pull-br-integration-test

ti-chi-bot · 2023-08-03T06:19:47Z

@lichunzhu: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test canary-scan-security
/test check-dev
/test check-dev2
/test mysql-test
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-br-integration-test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-ddl-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-mysql-connector-test
/test pull-sqllogic-test
/test pull-tiflash-test
/test unit-test

The following commands are available to trigger optional jobs:

/test pull-notify-when-compatibility-sections-changed

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2023-08-03T06:20:16Z

@lichunzhu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

GMHDBJD

LGTM

lance6716 · 2023-08-03T06:20:54Z

/lgtm

ti-chi-bot · 2023-08-03T06:20:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [GMHDBJD,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-08-03T06:21:01Z

[LGTM Timeline notifier]

Timeline:

2023-08-03 06:20:41.050982556 +0000 UTC m=+339124.993331087: ☑️ agreed by GMHDBJD.
2023-08-03 06:21:00.10958502 +0000 UTC m=+339144.051933551: ☑️ agreed by lance6716.

lichunzhu · 2023-08-03T07:41:12Z

/test pull-br-integration-test

ti-chi-bot · 2023-08-03T07:41:14Z

@lichunzhu: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test canary-scan-security
/test check-dev
/test check-dev2
/test mysql-test
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-br-integration-test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-ddl-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-mysql-connector-test
/test pull-sqllogic-test
/test pull-tiflash-test
/test unit-test

The following commands are available to trigger optional jobs:

/test pull-notify-when-compatibility-sections-changed

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2023-08-03T07:41:49Z

@lichunzhu: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…gcap#45749) close pingcap#45747

lance6716 · 2023-10-18T03:08:42Z

/cherry-pick release-7.1

ti-chi-bot · 2023-10-18T03:09:24Z

@lance6716: new pull request created to branch release-7.1: #47734.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

) (#47734) close #45747

fix lightning tls WithHost

7c863e6

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2023

fix bazel

4e5c9aa

lance6716 reviewed Aug 2, 2023

View reviewed changes

ti-chi-bot bot added the approved label Aug 2, 2023

cherry-pick pingcap#45742

bb979f2

GMHDBJD approved these changes Aug 3, 2023

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 3, 2023

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 3, 2023

ti-chi-bot bot merged commit d3836c9 into pingcap:master Aug 3, 2023

lichunzhu deleted the fixLightningTLS branch August 3, 2023 09:27

lichunzhu added a commit to ti-chi-bot/tidb that referenced this pull request Aug 3, 2023

lightning: fix lightning TLS.WithHost to access the correct host (pin…

2c261d8

…gcap#45749) close pingcap#45747

lichunzhu added a commit to ti-chi-bot/tidb that referenced this pull request Aug 16, 2023

cp pingcap#45749

4bf6c1f

ti-chi-bot mentioned this pull request Oct 18, 2023

lightning: fix lightning TLS.WithHost to access the correct host (#45749) #47734

Merged

1 task

ti-chi-bot bot pushed a commit that referenced this pull request Oct 18, 2023

lightning: fix lightning TLS.WithHost to access the correct host (#45749

e5004d8

) (#47734) close #45747

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lightning: fix lightning TLS.WithHost to access the correct host #45749

lightning: fix lightning TLS.WithHost to access the correct host #45749

lichunzhu commented Aug 2, 2023

tiprow bot commented Aug 2, 2023

lichunzhu commented Aug 2, 2023

codecov bot commented Aug 2, 2023 •

edited

Loading

lichunzhu commented Aug 2, 2023

lance6716 commented Aug 2, 2023

tiprow bot commented Aug 2, 2023

ti-chi-bot bot commented Aug 2, 2023

lichunzhu commented Aug 2, 2023 •

edited

Loading

lance6716 Aug 2, 2023

lichunzhu Aug 2, 2023

lance6716 commented Aug 2, 2023

lichunzhu commented Aug 3, 2023

ti-chi-bot bot commented Aug 3, 2023

tiprow bot commented Aug 3, 2023

GMHDBJD left a comment

lance6716 commented Aug 3, 2023

ti-chi-bot bot commented Aug 3, 2023

ti-chi-bot bot commented Aug 3, 2023

lichunzhu commented Aug 3, 2023

ti-chi-bot bot commented Aug 3, 2023

tiprow bot commented Aug 3, 2023

lance6716 commented Oct 18, 2023

ti-chi-bot commented Oct 18, 2023

lightning: fix lightning TLS.WithHost to access the correct host #45749

lightning: fix lightning TLS.WithHost to access the correct host #45749

Conversation

lichunzhu commented Aug 2, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

tiprow bot commented Aug 2, 2023

lichunzhu commented Aug 2, 2023

codecov bot commented Aug 2, 2023 • edited Loading

Codecov Report

lichunzhu commented Aug 2, 2023

lance6716 commented Aug 2, 2023

tiprow bot commented Aug 2, 2023

ti-chi-bot bot commented Aug 2, 2023

lichunzhu commented Aug 2, 2023 • edited Loading

lance6716 Aug 2, 2023

Choose a reason for hiding this comment

lichunzhu Aug 2, 2023

Choose a reason for hiding this comment

lance6716 commented Aug 2, 2023

lichunzhu commented Aug 3, 2023

ti-chi-bot bot commented Aug 3, 2023

tiprow bot commented Aug 3, 2023

GMHDBJD left a comment

Choose a reason for hiding this comment

lance6716 commented Aug 3, 2023

ti-chi-bot bot commented Aug 3, 2023

ti-chi-bot bot commented Aug 3, 2023

[LGTM Timeline notifier]

lichunzhu commented Aug 3, 2023

ti-chi-bot bot commented Aug 3, 2023

tiprow bot commented Aug 3, 2023

lance6716 commented Oct 18, 2023

ti-chi-bot commented Oct 18, 2023

codecov bot commented Aug 2, 2023 •

edited

Loading

lichunzhu commented Aug 2, 2023 •

edited

Loading