Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: improve TestNewImportSSTBackofferWithSucess #45683

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jul 31, 2023

What problem does this PR solve?

Issue Number: close #45684

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #45683 (8164661) into master (9794ea5) will increase coverage by 0.0398%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45683        +/-   ##
================================================
+ Coverage   73.2285%   73.2683%   +0.0397%     
================================================
  Files          1265       1268         +3     
  Lines        389826     390601       +775     
================================================
+ Hits         285464     286187       +723     
- Misses        86053      86093        +40     
- Partials      18309      18321        +12     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.2599% <ø> (+0.0313%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0417% <ø> (ø)
br 52.1351% <ø> (+0.0441%) ⬆️

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 31, 2023
@D3Hunter
Copy link
Contributor

@3pointer ptal

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 31, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 31, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-31 07:02:42.043974502 +0000 UTC m=+82445.986323027: ☑️ agreed by D3Hunter.
  • 2023-07-31 07:09:09.631507649 +0000 UTC m=+82833.573856412: ☑️ agreed by Leavrth.

@ti-chi-bot ti-chi-bot bot merged commit 697652f into pingcap:master Jul 31, 2023
18 of 32 checks passed
@hawkingrei hawkingrei deleted the improve_TestNewImportSSTBackofferWithSucess branch July 31, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestNewImportSSTBackofferWithSucess run for long time
3 participants