Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension: fix some wrong code for extension test #45656

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: ref #38788

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 28, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 28, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CbcWestwolf,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 28, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-28 08:30:24.85319971 +0000 UTC m=+515967.447730700: ☑️ agreed by CbcWestwolf.
  • 2023-07-28 08:32:08.475032029 +0000 UTC m=+516071.069563016: ☑️ agreed by hawkingrei.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #45656 (9a737ab) into master (ac0c90e) will decrease coverage by 0.0010%.
Report is 9 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45656        +/-   ##
================================================
- Coverage   73.2228%   73.2219%   -0.0010%     
================================================
  Files          1273       1276         +3     
  Lines        390068     390745       +677     
================================================
+ Hits         285619     286111       +492     
- Misses        86148      86287       +139     
- Partials      18301      18347        +46     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.2133% <0.0000%> (-0.0095%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0417% <ø> (-0.0109%) ⬇️
br 52.1520% <0.0000%> (+0.0021%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit 086952e into pingcap:master Jul 28, 2023
@lcwangchao lcwangchao deleted the fix_extension_case branch November 7, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants