timer,ttl: add some metrics for timer framework and TTL timer syncing #45611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
hawkingrei
reviewed
Jul 27, 2023
| @@ -68,6 +70,13 @@ type hookWorker struct { | |||
| ch chan *triggerEventRequest | |||
| logger *zap.Logger | |||
| nowFunc func() time.Time | |||
| // metrics for worker | |||
| triggerRequestCounter prometheus.Counter | |||
| onPreSchedEventCounter prometheus.Counter | |||
There was a problem hiding this comment.
We can create metrics package to support metrics for timer. such as executor/metrics.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #45611 +/- ##
================================================
- Coverage 73.2417% 73.2326% -0.0092%
================================================
Files 1269 1275 +6
Lines 389962 390752 +790
================================================
+ Hits 285615 286158 +543
- Misses 86046 86249 +203
- Partials 18301 18345 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/retest |
1 similar comment
|
/retest |
hawkingrei
approved these changes
Jul 28, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
YangKeao
approved these changes
Jul 28, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #45610
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.