Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Fix data race in TestSetLabelsConcurrentWithGetLabel (#45579) #45588

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #45579

What problem does this PR solve?

Issue Number: close #45578

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. severity/minor size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@5a5cad1). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #45588   +/-   ##
================================================
  Coverage               ?   73.4363%           
================================================
  Files                  ?       1080           
  Lines                  ?     346658           
  Branches               ?          0           
================================================
  Hits                   ?     254573           
  Misses                 ?      75644           
  Partials               ?      16441           

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 26, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 27, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [crazycs520,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 27, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-26 15:39:15.593835013 +0000 UTC m=+368898.188365989: ☑️ agreed by crazycs520.
  • 2023-07-27 08:45:23.259654494 +0000 UTC m=+430465.854185479: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 27, 2023
@ti-chi-bot ti-chi-bot bot merged commit da1e947 into pingcap:release-6.5 Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. severity/minor size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants