Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ttl: ttl use timer framework to trigger jobs #45469

Merged
merged 2 commits into from
Jul 26, 2023
Merged

ttl: ttl use timer framework to trigger jobs #45469

merged 2 commits into from
Jul 26, 2023

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #45468

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023 •
edited
Loading

Codecov Report

Merging #45469 (d3bdece) into master (f96ea53) will increase coverage by 0.5815%.
Report is 7 commits behind head on master.
The diff coverage is 74.9185%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #45469        +/-   ##
================================================
+ Coverage   73.2295%   73.8111%   +0.5815%     
================================================
  Files          1265       1270         +5     
  Lines        389624     395267      +5643     
================================================
+ Hits         285320     291751      +6431     
+ Misses        86005      85345       -660     
+ Partials      18299      18171       -128
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.8036% <74.9185%> (+0.5741%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0554% <ø> (ø)
br 52.1451% <ø> (+0.0084%) ⬆️

@lcwangchao
Copy link
Collaborator Author

/retest

@lcwangchao lcwangchao force-pushed the ttl_use_timer branch 2 times, most recently from 3569652 to c053155 Compare July 20, 2023 07:47
@lcwangchao lcwangchao requested review from YangKeao and bb7133 July 20, 2023 07:59
@hawkingrei
Copy link
Member

/test all

@lcwangchao
Copy link
Collaborator Author

/retest

YangKeao
YangKeao approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 24, 2023
bb7133
bb7133 reviewed Jul 26, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

timer/runtime/worker.go
@@ -26,7 +26,7 @@ import (
)

const (
workerRecvChanCap = 8
workerRecvChanCap = 128
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to enlarge this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make the timer trigger more smoothness when we have many timers in one hook (.i.e 1000 ttl tables)

bb7133
bb7133 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 26, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 26, 2023
@bb7133
Copy link
Member

bb7133 commented Jul 26, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 26, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-24 06:55:38.205488288 +0000 UTC m=+164680.800019273: ☑️ agreed by YangKeao.
  • 2023-07-26 03:46:31.97729271 +0000 UTC m=+326134.571823698: ☑️ agreed by bb7133.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 26, 2023

@bb7133: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lcwangchao
Copy link
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit c0459da into pingcap:master Jul 26, 2023
@lcwangchao lcwangchao deleted the ttl_use_timer branch August 7, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate TTL job schedule to timer framework
4 participants
@lcwangchao @hawkingrei @bb7133 @YangKeao