-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ttl: ttl use timer framework to trigger jobs #45469
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #45469 +/- ##
================================================
+ Coverage 73.2295% 73.8111% +0.5815%
================================================
Files 1265 1270 +5
Lines 389624 395267 +5643
================================================
+ Hits 285320 291751 +6431
+ Misses 86005 85345 -660
+ Partials 18299 18171 -128
Flags with carried forward coverage won't be shown. Click here to find out more.
|
6031e4e
to
4817e5a
Compare
/retest |
3569652
to
c053155
Compare
/test all |
c053155
to
d94b954
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -26,7 +26,7 @@ import ( | |||
) | |||
|
|||
const ( | |||
workerRecvChanCap = 8 | |||
workerRecvChanCap = 128 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to enlarge this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make the timer trigger more smoothness when we have many timers in one hook (.i.e 1000 ttl tables)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/merge |
@bb7133: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/retest |
What problem does this PR solve?
Issue Number: close #45468
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.