-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: fix lightning failed to log encoding error (#45241) #45364
lightning: fix lightning failed to log encoding error (#45241) #45364
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
/cc @lance6716 |
/cc @D3Hunter |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #45364 +/- ##
================================================
Coverage ? 73.4470%
================================================
Files ? 1080
Lines ? 347039
Branches ? 0
================================================
Hits ? 254890
Misses ? 75686
Partials ? 16463 |
This is an automated cherry-pick of #45241
What problem does this PR solve?
Issue Number: close #44321
Problem Summary:
When the source file has ill-formated row, the row is very large so it can't be logged. We can't locate the bad row;
What is changed and how it works?
When we encounter ill-formatted row, we take out the ill-formatted row and only log the first 1024 characters of the row, so that it would not report error that write length exceeds maximum file size.
Before fixing the issue, the log looks like this when encountering ill-formatted row:
The length of the row is 324.
After fixing the issue, the log looks like this when encountering ill-formatted row:
The length of the row is 2419.
So to check whether the "exceeds maximum file size" issue has been fixed, we could check whether the length of the row is larger than 500, which can make sure the log shows the first 1024 characters of the ill-formatted row instead of saying "write error: write length xxx exceeds maximum file size xxx".
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.