Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: move preSplitAndScatter to ddl worker #45234

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Jul 7, 2023

What problem does this PR solve?

Issue Number: close #44785

Problem Summary:

Before this PR, TiDB splits and scatters region after the DDL is complete. This may cause the issue that client waits a long time but the ddl info records only a few time.

What is changed and how it works?

As recommended in #44785 (comment), I moved preSplitAndScatter to DDL worker side.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 7, 2023
@tangenta tangenta requested a review from mjonss July 7, 2023 07:54
@tiprow
Copy link

tiprow bot commented Jul 7, 2023

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 7, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 7, 2023
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add manual test manual to the PR description?
Rest LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 10, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wjhuang2016, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [wjhuang2016,zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 12, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-10 03:59:15.898683096 +0000 UTC m=+304447.669021801: ☑️ agreed by zimulala.
  • 2023-07-12 05:26:44.557041478 +0000 UTC m=+482496.327380191: ☑️ agreed by wjhuang2016.

@ti-chi-bot ti-chi-bot bot merged commit 66ce2c7 into pingcap:master Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the time returned to the client is inconsistent with the ddl job info for truncate table
3 participants