Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn: Update client-go to fix the issue that GC BatchResolveLcok may miss primary pessimistic locks #45143

Conversation

MyonKeminta
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #45134

Problem Summary:

What is changed and how it works?

This PR update client-go dependency to include tikv/client-go#866 to fix the issue that BatchResolveLock may leave some primary pessimistic lock uncleared in some rare cases.

The issue is introduced while fixing #43243 . For branches that no release with #43243's fix was published, the release note is not needed.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that in some rare cases, some primary pessimistic locks may be left uncleared after GC.

…iss primary pessimistic locks

Signed-off-by: MyonKeminta <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 4, 2023
@tiprow
Copy link

tiprow bot commented Jul 4, 2023

Hi @MyonKeminta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MyonKeminta MyonKeminta requested review from cfzjywxk and ekexium July 4, 2023 08:16
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 4, 2023
Signed-off-by: MyonKeminta <[email protected]>
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 4, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 4, 2023
@MyonKeminta
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 4, 2023
@tiprow
Copy link

tiprow bot commented Jul 4, 2023

@MyonKeminta: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, ekexium

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-04 08:20:15.133288312 +0000 UTC m=+105647.066921733: ☑️ agreed by ekexium.
  • 2023-07-04 09:19:08.721923543 +0000 UTC m=+109180.655556965: ☑️ agreed by cfzjywxk.

@cfzjywxk
Copy link
Contributor

cfzjywxk commented Jul 4, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 4, 2023

@cfzjywxk: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 8588d76 into pingcap:master Jul 4, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #45151.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #45152.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #45153.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 4, 2023
@cfzjywxk cfzjywxk mentioned this pull request Jul 4, 2023
12 tasks
@MyonKeminta MyonKeminta deleted the m/fix-batch-resolve-lock-miss-primary-pessimistic-lock branch July 4, 2023 10:45
ti-chi-bot bot pushed a commit that referenced this pull request Jul 4, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Jul 12, 2023
MyonKeminta added a commit to ti-chi-bot/tidb that referenced this pull request Aug 8, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GC use BatchResolveLocks may miss some pessimistic locks in rare cases
4 participants