Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_control: support unquoted default group name #45047

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Jun 29, 2023

What problem does this PR solve?

Issue Number: ref #43180

Problem Summary:

What is changed and how it works?

Make parser support default(without quota, compare to default) as resource group name. The use experience should be a litter better because many user don't notice that default is a reserved keywork and need quoted when used as a identifier.

Before:

mysql> set resource group default;
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your TiDB version for the right syntax to use line 1 column 26 near "default"

mysql> set resource group `default`;
Query OK, 0 rows affected (0.01 sec)

After:

mysql> set resource group default;
Query OK, 0 rows affected (0.01 sec)

mysql> set resource group `default`;
Query OK, 0 rows affected (0.01 sec)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 29, 2023
@tiprow
Copy link

tiprow bot commented Jun 29, 2023

Hi @glorv. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@glorv
Copy link
Contributor Author

glorv commented Jun 29, 2023

/test all

@tiprow
Copy link

tiprow bot commented Jun 29, 2023

@glorv: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@glorv
Copy link
Contributor Author

glorv commented Jun 29, 2023

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jun 29, 2023
@glorv
Copy link
Contributor Author

glorv commented Jun 29, 2023

/test all

@tiprow
Copy link

tiprow bot commented Jun 29, 2023

@glorv: No jobs can be run with /test all.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/test tiprow_fast_test

@pingcap pingcap deleted a comment from ti-chi-bot bot Jun 29, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 29, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 29, 2023

@CabinfeverB: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@3pointer
Copy link
Contributor

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Jun 29, 2023
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 29, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, CabinfeverB, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 29, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-29 04:01:45.664941811 +0000 UTC m=+853071.066192259: ☑️ agreed by nolouch.
  • 2023-06-29 05:38:01.326811824 +0000 UTC m=+858846.728062272: ☑️ agreed by 3pointer.

@ti-chi-bot ti-chi-bot bot merged commit dec0ff7 into pingcap:master Jun 29, 2023
@glorv glorv deleted the default-rg branch June 29, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants