-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: union scan refactor, introduce the the mem rows iterator #44874
Conversation
Skipping CI for Draft Pull Request. |
/test tiprow_fast_test |
@hawkingrei: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/merge |
@tiancaiamao: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: ref #43249
Problem Summary:
This is the optimization of the UnionScan, part1
What is changed and how it works?
In the old code, all the mem buff rows are drained in the
unionscan.Open()
stage.The commit try to introduce a
memRowsIter
data struct, thememRowsIter
is built at theOpen
stage, but it does not fetch data in some cases(Now just handle the table reader and !desc).Instead, the
memRowsIter
provide theNext()
method for the caller to call it at theNext()
stage.Check List
Tests
Change the test case to 'select * from t limit 1'
And flamegraph before vs after:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.