*: Add GEOMETRY column type #44849

dveeden · 2023-06-20T14:44:45Z

What problem does this PR solve?

Issue Number: ref #6347

Problem Summary:

This adds a new column type: GEOMETRY that is compatible with MySQL.

This stores values in the format used by mysql

This is only the column type and does not yet add any functions for working with these. This is to limit the current scope. This makes it possible to migrate data from MySQL and view this data in tools like DBeaver. This also doesn't add support for SRID constraints yet.

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support for the GEOMETRY column type has been added

ti-chi-bot · 2023-06-20T14:44:48Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

dveeden · 2023-06-20T14:45:03Z

/test all

dveeden · 2023-06-20T14:54:47Z

/retest

dveeden · 2023-06-20T15:20:21Z

/retest

dveeden · 2023-06-20T15:31:34Z

/retest

hawkingrei · 2023-06-21T07:07:30Z

/test tiprow_test

hawkingrei · 2023-06-21T07:08:47Z

/test tiprow_fast_test

ti-chi-bot · 2023-06-21T07:08:49Z

@hawkingrei: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test canary-scan-security
/test check-dev
/test check-dev2
/test mysql-test
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-integration-br-test
/test pull-integration-mysql-test
/test unit-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mjonss

Are all the changes in DEPS.bzl, due to new dependencies?

mjonss · 2023-06-21T09:59:51Z

types/datum.go

+		fromBinary := d.Collation() == charset.CollationBin
+		toBinary := target.GetCharset() == charset.CharsetBin
+		if fromBinary && toBinary {
+			s = d.GetString()
+		} else if fromBinary {
+			s, err = d.GetBinaryStringDecoded(sc, target.GetCharset())
+		} else if toBinary {
+			s = d.GetBinaryStringEncoded()
+		} else {
+			s, err = d.GetStringWithCheck(sc, target.GetCharset())
+		}


This does not seem to be covered by the tests.

mjonss · 2023-06-21T10:00:08Z

types/datum.go

+	case KindBinaryLiteral:
+		s, err = d.GetBinaryStringDecoded(sc, target.GetCharset())
+	default:
+		return invalidConv(d, target.GetType())


Also not covered

dveeden · 2023-06-27T16:08:23Z

Are all the changes in DEPS.bzl, due to new dependencies?

Yes, I think so. You can check by unstaging the changes to DEPS.bzl and running make bazel_prepare.

$ git show -U0 -- DEPS.bzl | grep -E '^\+\s*importpath'
+        importpath = "github.com/Azure/go-ansiterm",
+        importpath = "github.com/cenkalti/backoff/v4",
+        importpath = "github.com/containerd/continuity",
+        importpath = "github.com/docker/cli",
+        importpath = "github.com/docker/docker",
+        importpath = "github.com/docker/go-connections",
+        importpath = "github.com/google/shlex",
+        importpath = "github.com/Microsoft/go-winio",
+        importpath = "github.com/moby/term",
+        importpath = "github.com/Nvveen/Gotty",
+        importpath = "github.com/opencontainers/go-digest",
+        importpath = "github.com/opencontainers/image-spec",
+        importpath = "github.com/opencontainers/runc",
+        importpath = "github.com/ory/dockertest/v3",
+        importpath = "github.com/twpayne/go-geom",
+        importpath = "github.com/twpayne/go-kml/v2",

$ go mod graph | grep -E '^github.com/twpayne/go-geom'
github.com/twpayne/[email protected] github.com/DATA-DOG/[email protected]
github.com/twpayne/[email protected] github.com/lib/[email protected]
github.com/twpayne/[email protected] github.com/ory/dockertest/[email protected]
github.com/twpayne/[email protected] github.com/stretchr/[email protected]
github.com/twpayne/[email protected] github.com/twpayne/go-kml/[email protected]
github.com/twpayne/[email protected] github.com/Azure/[email protected]
github.com/twpayne/[email protected] github.com/Microsoft/[email protected]
github.com/twpayne/[email protected] github.com/Nvveen/[email protected]
github.com/twpayne/[email protected] github.com/cenkalti/backoff/[email protected]
github.com/twpayne/[email protected] github.com/containerd/[email protected]
github.com/twpayne/[email protected] github.com/davecgh/[email protected]
github.com/twpayne/[email protected] github.com/docker/[email protected]+incompatible
github.com/twpayne/[email protected] github.com/docker/[email protected]+incompatible
github.com/twpayne/[email protected] github.com/docker/[email protected]
github.com/twpayne/[email protected] github.com/docker/[email protected]
github.com/twpayne/[email protected] github.com/gogo/[email protected]
github.com/twpayne/[email protected] github.com/google/[email protected]
github.com/twpayne/[email protected] github.com/imdario/[email protected]
github.com/twpayne/[email protected] github.com/mitchellh/[email protected]
github.com/twpayne/[email protected] github.com/moby/[email protected]
github.com/twpayne/[email protected] github.com/opencontainers/[email protected]
github.com/twpayne/[email protected] github.com/opencontainers/[email protected]
github.com/twpayne/[email protected] github.com/opencontainers/[email protected]
github.com/twpayne/[email protected] github.com/pkg/[email protected]
github.com/twpayne/[email protected] github.com/pmezard/[email protected]
github.com/twpayne/[email protected] github.com/sirupsen/[email protected]
github.com/twpayne/[email protected] github.com/xeipuuv/[email protected]
github.com/twpayne/[email protected] github.com/xeipuuv/[email protected]
github.com/twpayne/[email protected] github.com/xeipuuv/[email protected]
github.com/twpayne/[email protected] golang.org/x/[email protected]
github.com/twpayne/[email protected] golang.org/x/[email protected]
github.com/twpayne/[email protected] gopkg.in/[email protected]
github.com/twpayne/[email protected] gopkg.in/[email protected]

hawkingrei · 2023-06-27T16:11:21Z

/ok-to-test

dveeden · 2023-07-11T13:19:19Z

/retest

hawkingrei · 2023-07-11T13:46:35Z

/test all

hawkingrei · 2023-07-11T14:00:47Z

/retest

ti-chi-bot · 2023-07-18T15:17:03Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2023-08-07T13:26:04Z

Codecov Report

Merging #44849 (3456b68) into master (c0affea) will increase coverage by 2.1939%.
Report is 38 commits behind head on master.
The diff coverage is 87.5000%.

❗ Current head 3456b68 differs from pull request most recent head 1468d65. Consider uploading reports for the commit 1468d65 to get more accurate results

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #44849        +/-   ##
================================================
+ Coverage   71.0442%   73.2382%   +2.1939%     
================================================
  Files          1368       1259       -109     
  Lines        402977     388666     -14311     
================================================
- Hits         286292     284652      -1640     
+ Misses        96744      85765     -10979     
+ Partials      19941      18249      -1692

Flag	Coverage Δ
unit	`73.2382% <87.5000%> (+2.1939%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`53.6440% <ø> (-0.3224%)`	⬇️
parser	`85.0695% <ø> (∅)`
br	`52.0858% <ø> (-0.8856%)`	⬇️

ti-chi-bot · 2023-12-04T20:30:25Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133, d3hunter, tangenta, yudongusa for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS
pkg/parser/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2023-12-08T08:43:29Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2024-02-27T11:13:47Z

@dveeden: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
tiprow_fast_test	`1468d65`	link	true	`/test fast_test_tiprow`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot · 2024-11-18T09:04:50Z

@dveeden: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/build	`1468d65`	link	true	`/test build`
pull-mysql-client-test	`1468d65`	link	true	`/test pull-mysql-client-test`
idc-jenkins-ci-tidb/check_dev	`1468d65`	link	true	`/test check-dev`
idc-jenkins-ci-tidb/check_dev_2	`1468d65`	link	true	`/test check-dev2`
idc-jenkins-ci-tidb/mysql-test	`1468d65`	link	true	`/test mysql-test`
idc-jenkins-ci-tidb/unit-test	`1468d65`	link	true	`/test unit-test`
pull-integration-ddl-test	`1468d65`	link	true	`/test pull-integration-ddl-test`
pull-br-integration-test	`1468d65`	link	true	`/test pull-br-integration-test`
pull-lightning-integration-test	`1468d65`	link	true	`/test pull-lightning-integration-test`
pull-integration-e2e-test	`1468d65`	link	true	`/test pull-integration-e2e-test`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dveeden requested review from mjonss, hawkingrei and bb7133 June 20, 2023 14:49

dveeden force-pushed the geometry_type branch 2 times, most recently from 9f9bd27 to 6d208ea Compare June 20, 2023 14:54

dveeden force-pushed the geometry_type branch 2 times, most recently from f2fcc61 to 4276847 Compare June 20, 2023 15:19

dveeden force-pushed the geometry_type branch from 4276847 to 88c425e Compare June 20, 2023 15:30

dveeden marked this pull request as ready for review June 20, 2023 16:05

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 20, 2023

mjonss changed the title ~~parser: Add GEOMETRY column type~~ *: Add GEOMETRY column type Jun 21, 2023

mjonss reviewed Jun 21, 2023

View reviewed changes

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2023

pingcap deleted a comment from ti-chi-bot bot Jun 24, 2023

dveeden force-pushed the geometry_type branch from 88c425e to 7cf01a8 Compare June 27, 2023 16:08

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jun 27, 2023

dveeden force-pushed the geometry_type branch from 7cf01a8 to 42b9dbe Compare June 27, 2023 16:14

ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2023

dveeden force-pushed the geometry_type branch from 42b9dbe to c483d33 Compare June 27, 2023 16:41

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2023

ti-chi-bot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 6, 2023

ti-chi-bot bot deleted a comment from ti-chi-bot Jul 11, 2023

ti-chi-bot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 13, 2023

parser: Add GEOMETRY column type

1468d65

dveeden force-pushed the geometry_type branch from 3456b68 to 1468d65 Compare December 4, 2023 20:30

dveeden marked this pull request as draft December 4, 2023 20:44

ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2023

dveeden removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2023

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: Add GEOMETRY column type #44849

*: Add GEOMETRY column type #44849

dveeden commented Jun 20, 2023 •

edited

Loading

ti-chi-bot bot commented Jun 20, 2023

dveeden commented Jun 20, 2023

dveeden commented Jun 20, 2023

dveeden commented Jun 20, 2023

dveeden commented Jun 20, 2023

hawkingrei commented Jun 21, 2023

hawkingrei commented Jun 21, 2023

ti-chi-bot bot commented Jun 21, 2023

mjonss left a comment

mjonss Jun 21, 2023

mjonss Jun 21, 2023

dveeden commented Jun 27, 2023

hawkingrei commented Jun 27, 2023

dveeden commented Jul 11, 2023

hawkingrei commented Jul 11, 2023

hawkingrei commented Jul 11, 2023

ti-chi-bot bot commented Jul 18, 2023

codecov bot commented Aug 7, 2023 •

edited

Loading

ti-chi-bot bot commented Dec 4, 2023

ti-chi-bot bot commented Dec 8, 2023

tiprow bot commented Feb 27, 2024

ti-chi-bot bot commented Nov 18, 2024

*: Add GEOMETRY column type #44849

Are you sure you want to change the base?

*: Add GEOMETRY column type #44849

Conversation

dveeden commented Jun 20, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot bot commented Jun 20, 2023

dveeden commented Jun 20, 2023

dveeden commented Jun 20, 2023

dveeden commented Jun 20, 2023

dveeden commented Jun 20, 2023

hawkingrei commented Jun 21, 2023

hawkingrei commented Jun 21, 2023

ti-chi-bot bot commented Jun 21, 2023

mjonss left a comment

Choose a reason for hiding this comment

mjonss Jun 21, 2023

Choose a reason for hiding this comment

mjonss Jun 21, 2023

Choose a reason for hiding this comment

dveeden commented Jun 27, 2023

hawkingrei commented Jun 27, 2023

dveeden commented Jul 11, 2023

hawkingrei commented Jul 11, 2023

hawkingrei commented Jul 11, 2023

ti-chi-bot bot commented Jul 18, 2023

codecov bot commented Aug 7, 2023 • edited Loading

Codecov Report

ti-chi-bot bot commented Dec 4, 2023

ti-chi-bot bot commented Dec 8, 2023

tiprow bot commented Feb 27, 2024

ti-chi-bot bot commented Nov 18, 2024

dveeden commented Jun 20, 2023 •

edited

Loading

codecov bot commented Aug 7, 2023 •

edited

Loading