infoschema: update raw args to make it drop correct table in RENAME TABLE
(#44585)
#44595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #44585
What problem does this PR solve?
Issue Number: close #43714
Problem Summary:
Reproducible step:
#43341 changes the behavior of
RENAME TABLE
: it takes two schema versions to complete. However,applyDiff()
doesn't handle twoSchemaDiff
s properly. The same table is created twice ininfoschema
, causing the phantom described in #43714.What is changed and how it works?
During applying schema diff, we check if the table already exists before creating a new table. Thus, we can skip the second creation.
Other alternative fixes include
CREATE TABLE
with foreign key does).job.Args
at second step, so that it contains the new schema ID.job.Args
, it is hard to guarantee all the components that relying on this work correctly.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.