Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session, ddl: fix the nil point in TxnInfo (#44486) #44507

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #44486

What problem does this PR solve?

Issue Number: close #43829

Problem Summary:

processInfo := s.ShowProcess()
txnInfo.ConnectionID = processInfo.ID   // panic is this line.

What is changed and how it works?

  • Check if the processInfo is nil.
  • Delete the duplicate logic of getting processInfoID.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
    Hard to test. In UT we use the MockSessionManager, so can't to test it.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jun 8, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Jun 8, 2023
@zimulala zimulala closed this Jun 12, 2023
@zimulala zimulala reopened this Jun 29, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 4, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 24, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lcwangchao,tiancaiamao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-04 08:35:29.879965364 +0000 UTC m=+106561.813598786: ☑️ agreed by tiancaiamao.
  • 2023-08-08 08:37:32.988250916 +0000 UTC m=+15417.537266903: ☑️ agreed by lcwangchao.

@zimulala
Copy link
Contributor

zimulala commented Aug 8, 2023

/retest

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@585a3a6). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #44507   +/-   ##
================================================
  Coverage               ?   75.1571%           
================================================
  Files                  ?       1083           
  Lines                  ?     357664           
  Branches               ?          0           
================================================
  Hits                   ?     268810           
  Misses                 ?      72671           
  Partials               ?      16183           

@ti-chi-bot ti-chi-bot bot merged commit 398f4ce into pingcap:release-6.5 Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants