Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter: enable qf1004 #44447

Merged
merged 3 commits into from
Jun 6, 2023
Merged

linter: enable qf1004 #44447

merged 3 commits into from
Jun 6, 2023

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Jun 6, 2023

What problem does this PR solve?

Issue Number: ref #40786

Problem Summary:
enable QF1004 for lint.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Jun 6, 2023
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and zhangjinpeng87 June 6, 2023 09:04
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jun 6, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 6, 2023
@hawkingrei hawkingrei requested a review from lance6716 June 6, 2023 09:07
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 6, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 6, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 6, 2023
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Jun 6, 2023

/retest

1 similar comment
@lance6716
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 6, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-06 09:07:42.805492419 +0000 UTC m=+339249.078465208: ☑️ agreed by hawkingrei.
  • 2023-06-06 09:09:07.386989402 +0000 UTC m=+339333.659962185: ☑️ agreed by lance6716.
  • 2023-06-06 09:54:43.242889341 +0000 UTC m=+342069.515862125: ✖️🔁 reset by ywqzzy.
  • 2023-06-06 10:00:21.134796985 +0000 UTC m=+342407.407769768: ☑️ agreed by hawkingrei.
  • 2023-06-06 10:38:27.727840449 +0000 UTC m=+999.572475049: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit fcd20a3 into pingcap:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants