Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: enable revive for part code #44382

Merged
merged 16 commits into from
Jun 5, 2023
Merged

planner: enable revive for part code #44382

merged 16 commits into from
Jun 5, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jun 3, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #40786

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Jun 3, 2023
@ti-chi-bot ti-chi-bot bot requested review from D3Hunter and xhebox June 3, 2023 10:56
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 3, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 3, 2023
hawkingrei added 10 commits June 4, 2023 16:07
@hawkingrei
planner: enable revive
135e7c7 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
95e2d04 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
567bf8f 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
68eac21 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
bc0af7c 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
0e9a410 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
db82362 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
a5c2bc4 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
18db2be 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
c2be5d8 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei force-pushed the enable_revive_for_all_plan branch from 45f4e17 to c2be5d8 Compare June 4, 2023 08:13
hawkingrei added 6 commits June 4, 2023 16:25
@hawkingrei
update
eaf72e1 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
80dac55 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
9063b26 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
8e2c8be 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
518c1f0 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
3d175ca 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei requested a review from lance6716 June 5, 2023 01:29
@hawkingrei hawkingrei changed the title planner: enable revive planner: enable revive for part code Jun 5, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 5, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 5, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-03 16:01:44.120129429 +0000 UTC m=+104890.393102221: ☑️ agreed by tangenta.
  • 2023-06-05 02:12:33.752014092 +0000 UTC m=+227940.024986873: ☑️ agreed by lance6716.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lance6716,tangenta,xhebox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 87bd41b into pingcap:master Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@xhebox xhebox xhebox approved these changes

@lance6716 lance6716 lance6716 approved these changes

@D3Hunter D3Hunter Awaiting requested review from D3Hunter

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hawkingrei @lance6716 @xhebox @tangenta