Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: enable linter revive #44380

Merged
merged 2 commits into from
Jun 3, 2023
Merged

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Jun 2, 2023

What problem does this PR solve?

Issue Number: ref #40786

What is changed and how it works?

Enable revive for ddl package.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 2, 2023
@ti-chi-bot ti-chi-bot bot requested review from bb7133 and coocood June 2, 2023 13:53
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 2, 2023
@tangenta tangenta requested review from hawkingrei and Defined2014 and removed request for coocood and bb7133 June 2, 2023 13:56
build/nogo_config.json Outdated Show resolved Hide resolved
build/nogo_config.json Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 2, 2023
@hawkingrei hawkingrei requested a review from lance6716 June 2, 2023 14:42
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 3, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 3, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 3, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-02 14:09:40.250835586 +0000 UTC m=+11766.523808365: ☑️ agreed by hawkingrei.
  • 2023-06-03 04:34:57.462245218 +0000 UTC m=+63683.735218001: ☑️ agreed by Defined2014.

@hawkingrei
Copy link
Member

/merge

1 similar comment
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot ti-chi-bot bot merged commit ffea45b into pingcap:master Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants