Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linter: enable SA4018 and SA4004 #44276

Merged
merged 15 commits into from
May 31, 2023
Merged

linter: enable SA4018 and SA4004 #44276

merged 15 commits into from
May 31, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented May 30, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #40786

Problem Summary:

What is changed and how it works?

SA4004 - The loop exits unconditionally after one iteration
SA4018 - Self-assignment of variables

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei
linter: enable SA4018
23e3e49 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 30, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 30, 2023
@hawkingrei
update
0e24f90 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 30, 2023
hawkingrei added 4 commits May 30, 2023 16:55
@hawkingrei
update
4bbe138 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
8ec8b5c 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
3289776 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
7f80268 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei closed this May 30, 2023
@hawkingrei
update
a0c6f58 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei reopened this May 30, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 30, 2023
hawkingrei added 7 commits May 30, 2023 17:54
@hawkingrei
update
0fdb06f 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
0149b06 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
f4b7b1d 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update main_test
9ae080b 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update main_test
bd35e96 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update main_test
2c5ab65 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update main_test
5f96c54 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei changed the title linter: enable SA4018 linter: enable SA4018 and SA4004 May 31, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 31, 2023
lance6716
lance6716 reviewed May 31, 2023
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

server/http_status.go Outdated Show resolved Hide resolved
@hawkingrei
update main_test
6773aab 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 31, 2023
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 31, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 6773aab

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 31, 2023
@ti-chi-bot ti-chi-bot bot merged commit d3faf53 into pingcap:master May 31, 2023
@hawkingrei hawkingrei deleted the enable_sa4018 branch May 31, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@lance6716 lance6716 lance6716 approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hawkingrei @lance6716 @Defined2014