Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: del NO_BACKSLASH_ESCAPES sql mode for internal sql (#43966) #43994

Merged
merged 4 commits into from
May 23, 2023
Merged

session: del NO_BACKSLASH_ESCAPES sql mode for internal sql (#43966) #43994

merged 4 commits into from
May 23, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #43966

What problem does this PR solve?

Issue Number: close #43392

Problem Summary: As issue said, NO_BACKSLASH_ESCAPES may cause internal sql parse failed.

What is changed and how it works?

Delete NO_BACKSLASH_ESCAPES for internal sql mode.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot mentioned this pull request May 19, 2023
Merged
12 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 19, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YangKeao
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels May 19, 2023
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-5.3 labels May 19, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 19, 2023
guo-shaoge added 2 commits May 19, 2023 16:20
@guo-shaoge
fix conflict
0fb60f2 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
remove case
d7125fa 
Signed-off-by: guo-shaoge <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 19, 2023
YangKeao
YangKeao approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 19, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 22, 2023
@xhebox
Copy link
Contributor

xhebox commented May 22, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 22, 2023

This pull request has been accepted and is ready to merge.

Commit hash: d7125fa

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 22, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 22, 2023
@guo-shaoge
Copy link
Collaborator

/retest

@guo-shaoge
Copy link
Collaborator

/run-unit-test

@ti-chi-bot ti-chi-bot bot merged commit 55a0a57 into pingcap:release-5.3 May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@YangKeao YangKeao YangKeao approved these changes

Assignees

@guo-shaoge guo-shaoge

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @xhebox @guo-shaoge @YangKeao @VelocityLight