Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: add tags to snapshots and restored volumes #43933

Merged
merged 14 commits into from
May 22, 2023

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented May 17, 2023

What problem does this PR solve?

Issue Number: close #43934

Problem Summary:

What is changed and how it works?

  1. In CreateSnapshots, added tagging for the created snapshots
  2. In CreateVolumes, added tagging for the restored volumes using tags from the respective snapshots.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Verify the tags for snapshots and restored volume on real AWS environment using EBS BR.
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Add AWS tags to EBS volume snapshots and restored volumes in the BR tool.

Snapshots tags added:

- source/pvcName=<pvc_name>
- source/VolumeId=<volume-id>
- source/TikvName=<tikv_pod_name>
- source/Namespace=<k8s_namespace> 
- source/context=<k8s_cluster_name> 

Tags added for restored volumes:

ebs.csi.aws.com/cluster=true

- ebs.csi.aws.com/cluster=true
- snapshot/createdFromSnapshotId=<snapshot_id>
- snapshot/source/pvcName=<pvc_name>
- snapshot/source/VolumeId=<volume-id>
- snapshot/source/TikvName=<tikv_pod_name>
- snapshot/source/Namespace=<k8s_namespace> 
- snapshot/source/context=<k8s_context>

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 17, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YuJuncen
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels May 17, 2023
@BornChanger
Copy link
Contributor Author

/retest

go.mod Show resolved Hide resolved
@BornChanger BornChanger requested a review from a team as a code owner May 18, 2023 12:02
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 18, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 18, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 18, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 18, 2023
@BornChanger
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 19, 2023
@hawkingrei hawkingrei requested review from D3Hunter and removed request for a team May 19, 2023 08:47
@BornChanger
Copy link
Contributor Author

/cc @WangLe1321 @YuJuncen

@ti-chi-bot ti-chi-bot bot requested review from WangLe1321 and YuJuncen May 19, 2023 12:40
@BornChanger
Copy link
Contributor Author

/cc @3pointer

BornChanger and others added 12 commits May 22, 2023 16:50
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
Signed-off-by: BornChanger <[email protected]>
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 22, 2023

@WangLe1321: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/merge

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 22, 2023
@YuJuncen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 22, 2023

This pull request has been accepted and is ready to merge.

Commit hash: d7b63e7

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 22, 2023
@ti-chi-bot ti-chi-bot bot merged commit df0db33 into pingcap:master May 22, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #44063.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 22, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #44064.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br: add new tags for ebs br
5 participants