Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner, expression: fix wrong fieldtype after aggregationPushDownSolver #43906

Merged
merged 4 commits into from
May 18, 2023
Merged

planner, expression: fix wrong fieldtype after aggregationPushDownSolver #43906

merged 4 commits into from
May 18, 2023

Conversation

wshwsh12
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #43805
Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 17, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • XuHuaiyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels May 17, 2023
@wshwsh12
Copy link
Contributor Author

/cc @winoros @XuHuaiyu

@ti-chi-bot ti-chi-bot bot requested review from winoros and XuHuaiyu May 17, 2023 09:48
@XuHuaiyu XuHuaiyu added the type/bugfix This PR fixes a bug. label May 18, 2023
XuHuaiyu
XuHuaiyu reviewed May 18, 2023
View reviewed changes
planner/core/rule_aggregation_push_down.go
for i, funcsArgs := range oldAggFuncsArgs {
for j := range funcsArgs {
if oldAggFuncsArgs[i][j].GetType().EvalType() != newAggFuncsArgs[i][j].GetType().EvalType() {
noSideEffects = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break here?

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 18, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 18, 2023
@AilinKid
Copy link
Contributor

/retest

@hawkingrei
Copy link
Member

/test all

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 18, 2023

This pull request has been accepted and is ready to merge.

Commit hash: d6e83df

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit 0f3a2da into pingcap:master May 18, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 18, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #43971.

@ti-chi-bot ti-chi-bot mentioned this pull request May 18, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #43972.

@ti-chi-bot ti-chi-bot mentioned this pull request May 18, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43973.

@ti-chi-bot ti-chi-bot mentioned this pull request May 18, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #43974.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 18, 2023
@wshwsh12 @ti-chi-bot
planner, expression: fix wrong fieldtype after aggregationPushDownSol…
180d80e 
…ver (pingcap#43906)

close pingcap#43805
@ti-chi-bot ti-chi-bot mentioned this pull request May 18, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #43975.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 18, 2023
@wshwsh12 @ti-chi-bot
This is an automated cherry-pick of pingcap#43906
0e62230 
Signed-off-by: ti-chi-bot <[email protected]>
@zanmato1984
Copy link
Contributor

/run-cherry-picker

@ti-chi-bot ti-chi-bot mentioned this pull request May 18, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.2: #43976.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 18, 2023
@wshwsh12 @ti-chi-bot
This is an automated cherry-pick of pingcap#43906
282edbe 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request May 18, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.1: #43977.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 18, 2023
@wshwsh12 @ti-chi-bot
This is an automated cherry-pick of pingcap#43906
a2f45eb 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request May 19, 2023
@ti-chi-bot
planner, expression: fix wrong fieldtype after aggregationPushDownSol…
06afbbb 
…ver (#43906) (#43973)

close #43805
ti-chi-bot bot pushed a commit that referenced this pull request May 23, 2023
@ti-chi-bot
planner, expression: fix wrong fieldtype after aggregationPushDownSol…
65aabc9 
…ver (#43906) (#43974)

close #43805
ti-chi-bot bot pushed a commit that referenced this pull request May 23, 2023
@ti-chi-bot
planner, expression: fix wrong fieldtype after aggregationPushDownSol…
b0bf409 
…ver (#43906) (#43976)

close #43805
ti-chi-bot bot pushed a commit that referenced this pull request May 23, 2023
@ti-chi-bot
planner, expression: fix wrong fieldtype after aggregationPushDownSol…
bd8ecee 
…ver (#43906) (#43975)

close #43805
ti-chi-bot bot pushed a commit that referenced this pull request May 23, 2023
@ti-chi-bot
planner, expression: fix wrong fieldtype after aggregationPushDownSol…
d437007 
…ver (#43906) (#43977)

close #43805
ti-chi-bot bot pushed a commit that referenced this pull request May 23, 2023
@ti-chi-bot
planner, expression: fix wrong fieldtype after aggregationPushDownSol…
e87c251 
…ver (#43906) (#43971)

close #43805
ti-chi-bot bot pushed a commit that referenced this pull request May 23, 2023
@ti-chi-bot
planner, expression: fix wrong fieldtype after aggregationPushDownSol…
db63616 
…ver (#43906) (#43972)

close #43805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

max/min got wrong result
6 participants
@wshwsh12 @AilinKid @hawkingrei @ti-chi-bot @zanmato1984 @XuHuaiyu