-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Only warn of subpartitions, still allow first level partitioning (#41207) | tidb-test=pr/2193 #43887
ddl: Only warn of subpartitions, still allow first level partitioning (#41207) | tidb-test=pr/2193 #43887
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/retest |
1 similar comment
/retest |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #43887 +/- ##
================================================
Coverage ? 73.6595%
================================================
Files ? 1083
Lines ? 347336
Branches ? 0
================================================
Hits ? 255846
Misses ? 75074
Partials ? 16416 |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjonss, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
This is an automated cherry-pick of #41207
What problem does this PR solve?
Issue Number: close #41198 , close #41200
Problem Summary:
For LIST partitioning, it did not check if SUBPARTITION was used and just stripped the subpartition part
For RANGE and HASH partitioning it stripped all partitioning and added a warning that such partitioning was not supported.
What is changed and how it works?
Combine the two behaviours:
Strip the subpartitioning from the CREATE TABLE statement and issue a warning.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.