Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: Only warn of subpartitions, still allow first level partitioning (#41207) | tidb-test=pr/2193 #43887

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #41207

What problem does this PR solve?

Issue Number: close #41198 , close #41200

Problem Summary:
For LIST partitioning, it did not check if SUBPARTITION was used and just stripped the subpartition part
For RANGE and HASH partitioning it stripped all partitioning and added a warning that such partitioning was not supported.

What is changed and how it works?

Combine the two behaviours:
Strip the subpartitioning from the CREATE TABLE statement and issue a warning.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

If CREATE TABLE includes subpartitions, keep the normal partitioning and skip the subpartitioning + add a warning.

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 16, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 16, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 16, 2023
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. label May 16, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 16, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 6, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 6, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 6, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 15, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 24, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 1, 2023
@mjonss mjonss changed the title ddl: Only warn of subpartitions, still allow first level partitioning (#41207) ddl: Only warn of subpartitions, still allow first level partitioning (#41207) | tidb-test=pr/2193 Aug 1, 2023
@mjonss
Copy link
Contributor

mjonss commented Aug 1, 2023

/retest

1 similar comment
@mjonss
Copy link
Contributor

mjonss commented Aug 1, 2023

/retest

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@73892ba). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #43887   +/-   ##
================================================
  Coverage               ?   73.6595%           
================================================
  Files                  ?       1083           
  Lines                  ?     347336           
  Branches               ?          0           
================================================
  Hits                   ?     255846           
  Misses                 ?      75074           
  Partials               ?      16416           

@mjonss
Copy link
Contributor

mjonss commented Aug 1, 2023

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 2, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjonss, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 2, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 2, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-02 09:33:26.735576893 +0000 UTC m=+264290.677925424: ☑️ agreed by tiancaiamao.
  • 2023-08-02 10:12:17.860040937 +0000 UTC m=+266621.802389468: ☑️ agreed by mjonss.

@mjonss
Copy link
Contributor

mjonss commented Aug 2, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit 14d1167 into pingcap:release-6.5 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants