Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: fix oom when mem/cpu ratio is low #43729

Merged
merged 2 commits into from
May 12, 2023
Merged

lightning: fix oom when mem/cpu ratio is low #43729

merged 2 commits into from
May 12, 2023

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #43728

Problem Summary:

What is changed and how it works?

we ignore warnings when encoding rows now, but warnings uses the same memory as parser, since the input
row []types.Datum share the same underlying buf, and when doing CastValue, we're using hack.String/hack.Slice.
when generating error such as mysql.ErrDataOutOfRange, the data will be part of the error, causing the buf
unable to release. So we truncate the warnings.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • one csv file test, about 1g, each row is about 20k. add a sleep after encode this file, then get a memory profile

before

SEFXbEcoDA

after

JHzPzcRMCC

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 11, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • niubell

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2023
@D3Hunter D3Hunter changed the title lightning: fix oom when cpu/mem ratio is low lightning: fix oom when mem/cpu ratio is low May 11, 2023
lance6716
lance6716 approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the kernal's implementation (used by LOAD DATA) also has this problem?

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 11, 2023
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2023
@D3Hunter
Copy link
Contributor Author

@lance6716 ptal, test again, same result

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels May 11, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 11, 2023
@D3Hunter
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 11, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 8586481

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 11, 2023
@D3Hunter
Copy link
Contributor Author

/retest

@D3Hunter
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2023
@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

ci pass
https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_integration_br_test/detail/tidb_ghpr_integration_br_test/12554/pipeline

@D3Hunter
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2023
@D3Hunter
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot bot merged commit 56dacd0 into master May 12, 2023
@ti-chi-bot ti-chi-bot bot deleted the fix-oom-due-2-warn branch May 12, 2023 03:36
@ti-chi-bot ti-chi-bot mentioned this pull request May 12, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #43746.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 12, 2023
@D3Hunter @ti-chi-bot
This is an automated cherry-pick of pingcap#43729
e0a8340 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request May 12, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #43747.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 12, 2023
@D3Hunter @ti-chi-bot
This is an automated cherry-pick of pingcap#43729
3ef840c 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request May 12, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43748.

ti-chi-bot bot pushed a commit that referenced this pull request May 12, 2023
@ti-chi-bot
lightning: fix oom when mem/cpu ratio is low (#43729) (#43748)
fe089de 
close #43728
ti-chi-bot bot pushed a commit that referenced this pull request May 12, 2023
@ti-chi-bot
lightning: fix oom when mem/cpu ratio is low (#43729) (#43747)
d50dc76 
close #43728
ti-chi-bot bot pushed a commit that referenced this pull request May 12, 2023
@ti-chi-bot
lightning: fix oom when mem/cpu ratio is low (#43729) (#43746)
b00cc84 
close #43728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niubell niubell niubell approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lightning might oom when mem/cpu ratio is low
4 participants
@D3Hunter @ti-chi-bot @lance6716 @niubell