-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta/autoid: enable etcd client auto sync for autoid service #43529
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8150e70
|
/merge |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Affect tidb v6.4.0 above |
What problem does this PR solve?
Issue Number: close #42643
ref #9575, ref #33908
Problem Summary:
When the pd server change, the corresponding etcd address should be auto-refresh on the client side.
What is changed and how it works?
Because 1. tidb repo is too big, and it's not designed to be used as a lib. (this applies to all tidb/util/xxx), so the etcd client utility in the tidb repo is not a good place to be shared by other repos (tools / binlog ...)
2. For autoid service, it's a indenpendent component, the code is put to the tidb repo though. So this case is similiar to tools etc.
It should have shared the same etcd client instance, but it's not available when the server startup.
Maybe we can maintain a
pingcap/etcdutil
lib to solve the " 4 different etcd clients" issueCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.