Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: limit the concurrent number of ingest jobs to 1 #43210

Merged
merged 12 commits into from
Apr 20, 2023
Merged

ddl: limit the concurrent number of ingest jobs to 1 #43210

merged 12 commits into from
Apr 20, 2023

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Apr 19, 2023 •
edited by Benjamin2037
Loading

What problem does this PR solve?

Issue Number: close #42903

Problem Summary:

What is changed and how it works?

  • Add a unit test for pickBackfillType.
  • Register the backend context immediately after checking the env is available.
  • For some of the errors, we don't fall back to txn-merge mode anymore.
  • Add a pre-check that if the disk available space is less than 10%, an error is reported.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@tangenta tangenta requested a review from a team as a code owner April 19, 2023 13:10
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 19, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Benjamin2037
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 19, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 20, 2023
@Benjamin2037 Benjamin2037 removed the request for review from a team April 20, 2023 08:04
Benjamin2037
Benjamin2037 reviewed Apr 20, 2023
View reviewed changes
ddl/index.go
@@ -622,7 +622,11 @@ func (w *worker) onCreateIndex(d *ddlCtx, t *meta.Meta, job *model.Job, isPK boo
switch indexInfo.State {
case model.StateNone:
// none -> delete only
reorgTp := pickBackfillType(job)
var reorgTp model.ReorgType
reorgTp, err = pickBackfillType(w.ctx, job, indexInfo.Unique)
Copy link
Collaborator

@Benjamin2037 Benjamin2037 Apr 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if return err，can will still run add index？Or when there is err for lightning mode, can we all use txnMerge?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if return err，can will still run add index？

No. Users should check their configuration and fix the issue, or turn off tidb_ddl_enable_fast_reorg.

Or when there is err for lightning mode, can we all use txnMerge?

If something goes wrong halfway through the execution, it will fallback to txn-merge mode.

@tangenta
Copy link
Contributor Author

/retest

Benjamin2037
Benjamin2037 approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 20, 2023
@tangenta
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c43a21d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 20, 2023
@ti-chi-bot ti-chi-bot merged commit 1182231 into pingcap:master Apr 20, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 20, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #43262.

ti-chi-bot added a commit that referenced this pull request Apr 21, 2023
@ti-chi-bot
ddl: limit the concurrent number of ingest jobs to 1 (#43210) (#43262)
e96e604 
close #42903
@tangenta tangenta mentioned this pull request Jul 19, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 20, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

more than one add index ddl jobs triggered with ingest type
4 participants
@tangenta @ti-chi-bot @Benjamin2037 @wjhuang2016