Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix bug that table name in 'admin show ddl jobs' is missing for ongoing drop table operation #42904

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #42268

Problem Summary:

What is changed and how it works?

During drop table, the table is removed from the infoschema
So getTableName found nothing.
This cause the missing of the table name in 'admin show ddl jobs' result.

On the master branch, we can get the table name by job.TableName.
For older tidb, there is no TableName field, we need some other way to fix it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix a bug that table name in 'admin show ddl jobs' is missing for ongoing drop table operation

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 10, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • bb7133

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.0 size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 10, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 10, 2023
tiancaiamao added a commit to tiancaiamao/tidb that referenced this pull request Apr 10, 2023
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 11, 2023
@bb7133
Copy link
Member

bb7133 commented Apr 11, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7b52744

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 11, 2023
@tiancaiamao
Copy link
Contributor Author

/merge

@tiancaiamao
Copy link
Contributor Author

/run-unit-test

@tiancaiamao
Copy link
Contributor Author

/test unit-test

1 similar comment
@tiancaiamao
Copy link
Contributor Author

/test unit-test

ti-chi-bot pushed a commit that referenced this pull request Apr 11, 2023
@hawkingrei
Copy link
Member

/retest

1 similar comment
@tiancaiamao
Copy link
Contributor Author

/retest

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #42945.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #42946.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.0: #42947.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.2: #42948.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.3: #42949.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.4: #42950.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #42951.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #42952.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #42953.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 11, 2023
@tiancaiamao tiancaiamao deleted the issue-42268 branch April 12, 2023 02:49
@ti-chi-bot
Copy link
Member

@tiancaiamao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 7b52744 link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot bot pushed a commit that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.0 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing table name in admin show ddl result during drop table
5 participants