Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory: support cluster_hardware get memory info from cgroup #42850

Merged
merged 2 commits into from
Apr 7, 2023
Merged

memory: support cluster_hardware get memory info from cgroup #42850

merged 2 commits into from
Apr 7, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Apr 7, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #42851

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 7, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • zhongzc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 7, 2023
@XuHuaiyu XuHuaiyu mentioned this pull request Apr 7, 2023
Merged
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed do-not-merge/needs-linked-issue labels Apr 7, 2023
@hawkingrei
update
da35974 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 7, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 7, 2023
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: da35974

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2023
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot merged commit bd3a036 into pingcap:master Apr 7, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #42854.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 7, 2023
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#42850
5c4fd0f 
Signed-off-by: ti-chi-bot <[email protected]>
@hawkingrei hawkingrei deleted the support_cgroup_memory branch April 12, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongzc zhongzc zhongzc approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

information_schema.cluster_hardware get wrong value in the container
4 participants
@hawkingrei @ti-chi-bot @XuHuaiyu @zhongzc