Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain: fix empty mvcc info #42745

Merged
merged 1 commit into from
Apr 3, 2023
Merged

domain: fix empty mvcc info #42745

merged 1 commit into from
Apr 3, 2023

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Apr 3, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #42742

Problem Summary: This may be nil under some tests.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 3, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 3, 2023
@xhebox
Copy link
Contributor Author

xhebox commented Apr 3, 2023

/run-check-issue-triage-complete

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. do-not-merge/needs-triage-completed labels Apr 3, 2023
@xhebox
Copy link
Contributor Author

xhebox commented Apr 3, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1bc4e49

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 3, 2023
@hawkingrei
Copy link
Member

/retest

@Defined2014
Copy link
Contributor

/test unit-test

@xhebox
Copy link
Contributor Author

xhebox commented Apr 3, 2023

/retest

3 similar comments
@xhebox
Copy link
Contributor Author

xhebox commented Apr 3, 2023

/retest

@xhebox
Copy link
Contributor Author

xhebox commented Apr 3, 2023

/retest

@xhebox
Copy link
Contributor Author

xhebox commented Apr 3, 2023

/retest

@hawkingrei
Copy link
Member

/test all

@xhebox
Copy link
Contributor Author

xhebox commented Apr 3, 2023

/retest

4 similar comments
@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/retest

@xhebox
Copy link
Contributor Author

xhebox commented Apr 3, 2023

/retest

@xhebox
Copy link
Contributor Author

xhebox commented Apr 3, 2023

/retest-required

@hawkingrei
Copy link
Member

/merge

@hawkingrei
Copy link
Member

/retest

4 similar comments
@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot merged commit acc45a1 into pingcap:master Apr 3, 2023
@ti-chi-bot
Copy link
Member

@xhebox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 1bc4e49 link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

crazycs520 pushed a commit to crazycs520/tidb that referenced this pull request Sep 1, 2023
@xhebox @crazycs520
domain: fix empty mvcc info (pingcap#42745)
298bb31 
close pingcap#42742
@zyguan zyguan mentioned this pull request Sep 1, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

report "runtime error: invalid memory address or nil pointer dereference" when create table
5 participants
@xhebox @ti-chi-bot @hawkingrei @Defined2014 @lcwangchao