Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

execdetails: fix data race in the BasicRuntimeStats #42338

Merged
merged 5 commits into from
Mar 17, 2023
Merged

execdetails: fix data race in the BasicRuntimeStats #42338

merged 5 commits into from
Mar 17, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Mar 16, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #42337

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 16, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Mar 16, 2023
@hawkingrei
update
ad63f01 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
403a25c 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
9897a2a 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
645dffc 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 17, 2023
Defined2014
Defined2014 approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@Defined2014 Defined2014 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it will influence performance or not, but aprrove it firstly

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2023
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 645dffc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2023
@ti-chi-bot ti-chi-bot merged commit ed86b9c into pingcap:master Mar 17, 2023
@lcwangchao
Copy link
Collaborator

/cherry-pick 6.5

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 22, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

@lcwangchao: new pull request created to branch 6.5: #49696.

In response to this:

/cherry-pick 6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 22, 2023
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#42338
aaf65bf 
Signed-off-by: ti-chi-bot <[email protected]>
@lcwangchao
Copy link
Collaborator

/cherry-pick release-6.5

@ti-chi-bot
Copy link
Member

@lcwangchao: new pull request created to branch release-6.5: #49698.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 22, 2023
Merged
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 22, 2023
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#42338
64218bb 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Dec 22, 2023
@ti-chi-bot
execdetails: fix data race in the BasicRuntimeStats (#42338) (#49698)
13eeb6a 
close #42337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@lance6716 lance6716 lance6716 approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DATA RACE in the BasicRuntimeStats
5 participants
@hawkingrei @ti-chi-bot @lcwangchao @lance6716 @Defined2014